refactor: replace terminal package used by oras login
#910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qweeah
requested review from
sajayantony,
shizhMSFT,
SteveLasker and
TerryHowe
as code owners
shizhMSFT
reviewed
Mar 29, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #910 +/- ##
==========================================
+ Coverage 78.76% 79.67% +0.90%
==========================================
Files 52 53 +1
Lines 2840 2853 +13
==========================================
+ Hits 2237 2273 +36
+ Misses 429 399 -30
- Partials 174 181 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
TerryHowe
reviewed
Mar 29, 2023
qweeah
force-pushed
the
update-term
branch
2 times, most recently
from
824398a
to
84c1f24
Compare
shizhMSFT
reviewed
Mar 30, 2023
4 tasks
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT
reviewed
Apr 10, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
This was referenced Jul 5, 2023
shizhMSFT
pushed a commit
to shizhMSFT/oras
that referenced
this pull request
Aug 3, 2023
…#910) Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates the underlying package of
oras loginwith minor refactoring.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #908
Please check the following list: