Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make e2e coverage data in action #926

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Apr 13, 2023

What this PR does / why we need it:
As a follow-up of #924, this PR moves the action of coverage data generation out of e2e run script.
Also added some e2e specs to validate the changes.

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter
Copy link

Codecov Report

Merging #926 (cffe449) into main (9d7edb9) will increase coverage by 0.21%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #926      +/-   ##
==========================================
+ Coverage   80.09%   80.30%   +0.21%     
==========================================
  Files          53       53              
  Lines        2853     2853              
==========================================
+ Hits         2285     2291       +6     
+ Misses        388      383       -5     
+ Partials      180      179       -1     

see 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 676a8ed into oras-project:main Apr 13, 2023
shizhMSFT pushed a commit to shizhMSFT/oras that referenced this pull request Aug 3, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants