Skip to content

Commit

Permalink
fix: s390x architecture is not handled (#57)
Browse files Browse the repository at this point in the history
The project releases s390x binaries (64bit), but not s390 (31bit). Node
reports a s390x runner correctly as "s390x", so instllations will fail
on this platform.

https://nodejs.org/api/os.html#osarch

Hence the s390 arch case has been changed to the s390x.

Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
  • Loading branch information
mkulke authored Oct 21, 2024
1 parent c730dd0 commit 2a4cd09
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion dist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -6752,7 +6752,7 @@ function mapArch() {
return 'ppc64le';
case 'riscv64':
return 'riscv64';
case 's390':
case 's390x':
return 's390x';
case 'arm':
return 'armv7';
Expand Down
4 changes: 2 additions & 2 deletions src/lib/release.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export function mapArch(): string {
return 'ppc64le';
case 'riscv64':
return 'riscv64';
case 's390':
case 's390x':
return 's390x';
case 'arm':
return 'armv7';
Expand All @@ -104,4 +104,4 @@ export function mapArch(): string {
export function getBinaryExtension(): string {
const platform = mapPlatform();
return platform === 'windows' ? '.exe' : '';
}
}

0 comments on commit 2a4cd09

Please sign in to comment.