oradb_rman: added option state for cronjobs, disabled is optional now

Cronjobs could be removed when state=absent is set.
oravirt · Aug 10, 2023 · 027ca01 · 027ca01
1 parent d148d8c
commit 027ca01
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/changelogs/fragments/rman_cron.yml b/changelogs/fragments/rman_cron.yml
@@ -0,0 +1,3 @@
+---
+minor_changes:
+  - "oradb_rman: added option state for cronjobs, disabled is optional now (oravirt#369)"
diff --git a/roles/oradb_rman/tasks/main.yml b/roles/oradb_rman/tasks/main.yml
@@ -342,7 +342,8 @@
     name: rman_backup_{{ item.0.oracle_db_name }}_{{ item.1.name }}
     cron_file: "{{ rman_cronfile }}"
     user: "{{ oracle_user }}"
-    disabled: "{{ item.1.disabled }}"
+    disabled: "{{ item.1.disabled | default(false) }}"
+    state: "{{ item.1.state | default('present') }}"
     day: "{{ item.1.day }}"
     weekday: "{{ item.1.weekday }}"
     hour: "{{ item.1.hour }}"
@@ -354,10 +355,13 @@
     - rman_jobs
     - skip_missing: true
   loop_control:
-    label: "oracle_db_name {{ item.0.oracle_db_name | default('') }} job {{ item.1.name | default('') }}"
+    label: >-
+      oracle_db_name: {{ item.0.oracle_db_name | default('') }}
+      job: {{ item.1.name | default('') }}
+      disabled: {{ item.1.disabled | default(false) }}
+      state: {{ item.1.state | default('present') }}
   when:
     - item.1 is defined
-    - item.1.disabled is defined
     - item.1.day is defined
     - item.1.weekday is defined
     - item.1.hour is defined