Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the deployment of ocenv configurable #285

Merged
merged 2 commits into from
Oct 11, 2022

Conversation

talek
Copy link
Contributor

@talek talek commented Oct 11, 2022

While I can understand the utility of the ocenv script, it should be possible to decide if you want it deployed or not.

@Rendanic Rendanic added this to the 3.2.0 milestone Oct 11, 2022
@Rendanic
Copy link
Collaborator

Idea is great. Could you rebase your branch against the current master?
You have included the commits from your previous PR.

@talek
Copy link
Contributor Author

talek commented Oct 11, 2022

Sorry about that, I've rebased the branch, hope that's fine now. Thanks!

@Rendanic
Copy link
Collaborator

No problem. Thanks for the contribution. The switch is absolutly fine for me.
ocenv is a fatantastic environment script with tons of feautures - amazing work from a colleague.

@Rendanic Rendanic merged commit a14231f into oravirt:master Oct 11, 2022
@talek talek deleted the ocenv_config branch October 12, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants