Add option to set the path of the dbca template #292
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
dbca_templatename
can't refer to a file outside of the./templates
sub-directory. This is a problem if you maintain a location with various dbca template files, outside of the role/playbook structure. So, it should be possible to provide the source path of the dbca template as well. I know that you can setdbca_copy_template
tofalse
and copy the template file yourself, but I feel thatoradb_manage_db
role should be smart enough to handle this simple scenario by its own. Another way to address this would be to specify the full path as part of thedbca_templatename
property and apply abasename
filter here and there, but I think it is more complicated and it doesn't pay off the trouble.