Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set the path of the dbca template #292

Merged
merged 2 commits into from
Nov 7, 2022

Conversation

talek
Copy link
Contributor

@talek talek commented Nov 6, 2022

Currently dbca_templatename can't refer to a file outside of the ./templates sub-directory. This is a problem if you maintain a location with various dbca template files, outside of the role/playbook structure. So, it should be possible to provide the source path of the dbca template as well. I know that you can set dbca_copy_template to false and copy the template file yourself, but I feel that oradb_manage_db role should be smart enough to handle this simple scenario by its own. Another way to address this would be to specify the full path as part of the dbca_templatename property and apply a basename filter here and there, but I think it is more complicated and it doesn't pay off the trouble.

@Rendanic Rendanic added this to the 3.3.0 milestone Nov 7, 2022
@Rendanic
Copy link
Collaborator

Rendanic commented Nov 7, 2022

Great idea, looks fine for me.

@Rendanic Rendanic merged commit 1d308e0 into oravirt:master Nov 7, 2022
@talek talek deleted the dbtemplate_path branch November 10, 2022 09:47
@Rendanic Rendanic mentioned this pull request Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants