fix to enable removal of old jobs #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartowl
force-pushed
the
bugfix/copy_rman_scripts
branch
from
e6695ca
to
d19b5d1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR (#369) did allow removal of crontab jobs by specifying
state: absenton rman_jobs entries. It however still tries to copy the rman script (which when state=absent does not really make sense and may even result in error if custom rman script got already removed/renamed on controller) and requires to add all time-related field options.With this PR the task has been split into 2 - one task that will create required jobs (with state=present), and another one that will remove only the tasks with state=absent without requirement to provide
hour,minute,weekdayetc. Only name and state=absent is needed for removal. In addition the role will not try to copy rman scripts for which the state has been set to absent. It will however not remove them either from systems. They will be left for eventual manual deletion.