fix loops #416
Merged
fix loops #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do not merge yet... |
- replace match filter with equalto where applicable
bartowl
force-pushed
the
feature/oradb-facts-ignore-errors
branch
from
1045bef
to
c01f92a
Compare
bartowl
force-pushed
the
feature/oradb-facts-ignore-errors
branch
from
c01f92a
to
88cffef
Compare
|
Big thanks for finding and fixing this bug! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes many roles where
loop:caused to evaluate only first element fromoracle_databases/oracle_pdbs.It also changes the
matchfilter in probably allselectattr()calls as there exact match is needed, andmatchfilter actually matches only beginning of the string/line thus creating a possibility to include also partial matches which would cause problems.One last touch is change in oradb_facts role, as it used global fact variables and not those from registered variable, which (when using for example ignore_errors) might led to a situation where facts for one failed database would be set to those from previous loop element. It may never occur, yet this way it is just safer.