bug: extra indents in yaml blocks produce unwanted newlines #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It showed particulary in oradb_rman role, where due to additional indents in
>-block unwanted newlines were produced by builtin.shell command line, which caused the task to fail. Due to the syntax of commandline produced this however did not produce exitcode != 0 and was not recognised as failed by ansible.Here is how a command looked like:
cmd: "/u01/app/oracle/bin/rman_backup.sh\n -a parameter\n -s CDB1\n -r /u01/app/oracle/rman\n -l /u01/app/oracle/rman/log | tee -a /var/log/oracle/rman/log/rman_parameter.log"
This of course produced following output:
stdout: "Missing parameter for ORACLE_SID\n \nUsage:\n rman_backup.sh -a -s <ORACLE_SID|DB_NAME> [-r ]\n [-l ] [-c ] [-t ]\n [--service <Servicename in GI/Restart>]\n rman_backup.sh -h",
Similar problems, yet rather optical than functional have been corrected over entire roles/ code basis. Only where extra indenting was done inside {{ ... }} blocks, it has not been removed, as it did not introduce any unexpected newlines.