Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject failed transactions in TransactionProcessor + commitment fix #24

Merged
merged 6 commits into from
Jan 26, 2023
Merged

Reject failed transactions in TransactionProcessor + commitment fix #24

merged 6 commits into from
Jan 26, 2023

Conversation

odcheung
Copy link
Collaborator

#22 was reverted in v0.1.8 due to a bug in the commit.

Testing

  • Verified on local build that whirlpools-sdk tests all pass.
  • Verified on Orca UI that transactions function accordingly

rawfalafel
rawfalafel approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@rawfalafel rawfalafel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@rawfalafel rawfalafel merged commit 83315db into main Jan 26, 2023
@rawfalafel rawfalafel deleted the meep/tb-fix branch January 26, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawfalafel rawfalafel rawfalafel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odcheung @rawfalafel