mintlist-cli: Adding a bump comand that diffs mintlists and overrides #36
Conversation
| // Returns true if a mintlist.json file was added or removed, false otherwise | ||
| function hasMintlistChanges(before: string, after: string) { | ||
| const beforeMintlists = toMintlistFilePaths( | ||
| execSync(`git ls-tree --name-only ${before} src/mintlists`, { |
There was a problem hiding this comment.
I don't think the restriction that mintlist files can only be placed under src/mintlists is present elsewhere in this command.
How about leaving it to the filtering process in toMintlistFilePaths ? (not provide path here)
There was a problem hiding this comment.
@terranmoccasin
Oh, sorry.
My point is that this bump constrains mintlist to be under src/mintlists directory only, but add-mint/remove-mint/gen-tokenlist does not have that constraint. ./hoge.mintlist.json and ./src/fuga.mintlist.json also appear to be possible.
As with overrides.json, how about forcing the mintlist file to be placed under src/mintlists, or have bump detect the mintlist file for the entire directory.
Personally, I think it is reasonable to force users to use the following directory/file structure.
src/overrides.json
src/mintlists/x.mintlist.json
src/mintlists/y.mintlist.json
...
|
Hey @yugure-orca thanks for the suggestions. I've addressed them all and this is ready for another look! |
|
@terranmoccasin |
Adding a
bumpcommand that diffs mintlists to update the package version.