Tweak sign order at TransactionProcessor #78
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm, I want to test by creating new position with LiquidityTerminal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransactionProcessor have been deprecated, but it is used in LiquidityTerminal.
Backpack can adjust priority fee setting, but it works for not signed transaction only because partially signed transaction is not rewritable (without signature breaking).
In TransactionProcessor, signing order is signers -> wallet. Signers includes keypair used to create temporary SOL account, etc. So I'm testing this tweak with X/SOL pool position.
Without this teak
Backpack cannot rewrite partially signed transaction.
With this tweak
Backpack cannot rewrite transaction.
