Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add and activate point robinson & sunset bay hydrophones #136

Merged
merged 2 commits into from
Nov 4, 2023

Conversation

salsal97
Copy link
Contributor

Updated documentation
Added two new hydrophones
Fixed small typos

InferenceSystem/src/LiveInferenceOrchestrator.py Outdated Show resolved Hide resolved
InferenceSystem/src/globals.py Show resolved Hide resolved
InferenceSystem/deploy/point-robinson.yaml Show resolved Hide resolved
@salsal97
Copy link
Contributor Author

@micya can you merge if we are ready

@scottveirs
Copy link
Member

scottveirs commented Nov 4, 2023

Thanks again for hacking with us @salsal97 ! Since the Sept Hackathon we've received at least one notification of a new candidates from Sunset Bay and many from Point Robinson, so we know the new containers are functional...

...but can you or @micya explain how that is possible if this PR has not yet been merged?

My guess is that the setup of both new containers was done manually (like you did with Point Robinson, Saloni, as an in-person tutorial for me and Dave) via the steps you've refined... but if so, this PR should still be merged so we get the improvements in documentation and the new .yml files, right?

@salsal97
Copy link
Contributor Author

salsal97 commented Nov 4, 2023

Hi @scottveirs, glad it’s working fine!

So the code is in a container and already in kubernetes, even if the PR Isn’t necessarily merged. The docker container has a copy of it all and that’s how it’s working already. The container doesn’t refresh with every PR merge - refreshing it is a manual process.

So that part of the thread is already ahead, and merging the PR is definitely essential for future alignment with our new hydrophones. Since I don’t have permission to merge, I’d be dependent on either of you to make that final merge if this version of the PR looks good.

@micya micya merged commit 712c693 into orcasound:main Nov 4, 2023
@micya
Copy link
Member

micya commented Nov 4, 2023

Apologies for the late reply. Thanks @salsal97 !

@micya
Copy link
Member

micya commented Nov 4, 2023

It might be useful to add some kind of GitHub pipeline to handle auto rollout based on committed yaml files. Maybe something for next hack?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants