Allocate remainder when splitting runes

ordinals · Dec 23, 2023 · 3b631c0 · 3b631c0
1 parent d856b05
commit 3b631c0
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 16 deletions.
diff --git a/src/index/updater/rune_updater.rs b/src/index/updater/rune_updater.rs
@@ -221,9 +221,14 @@ impl<'a, 'db, 'tx> RuneUpdater<'a, 'db, 'tx> {
             if amount == 0 {
               // if amount is zero, divide balance between eligible outputs
               let amount = *balance / destinations.len() as u128;
-
-              for output in destinations {
-                allocate(balance, amount, output);
+              let remainder = usize::try_from(*balance % destinations.len() as u128).unwrap();
+
+              for (i, output) in destinations.iter().enumerate() {
+                allocate(
+                  balance,
+                  if i < remainder { amount + 1 } else { amount },
+                  *output,
+                );
               }
             } else {
               // if amount is non-zero, distribute amount to eligible outputs

diff --git a/src/runes.rs b/src/runes.rs
@@ -2770,23 +2770,23 @@ mod tests {
         RuneEntry {
           etching: txid,
           rune: Rune(RUNE),
-          supply: (u128::max_value() / 4) * 4,
+          supply: u128::max_value(),
           timestamp: 2,
           ..Default::default()
         },
       )],
       [
         (
           OutPoint { txid, vout: 0 },
-          vec![(id, u128::max_value() / 4)],
+          vec![(id, u128::max_value() / 4 + 1)],
         ),
         (
           OutPoint { txid, vout: 1 },
-          vec![(id, u128::max_value() / 4)],
+          vec![(id, u128::max_value() / 4 + 1)],
         ),
         (
           OutPoint { txid, vout: 2 },
-          vec![(id, u128::max_value() / 4)],
+          vec![(id, u128::max_value() / 4 + 1)],
         ),
         (
           OutPoint { txid, vout: 3 },
@@ -2843,23 +2843,23 @@ mod tests {
         RuneEntry {
           etching: txid,
           rune: Rune(RUNE),
-          supply: 1000 + ((u128::max_value() - 1000) / 4) * 4,
+          supply: u128::max_value(),
           timestamp: 2,
           ..Default::default()
         },
       )],
       [
         (
           OutPoint { txid, vout: 0 },
-          vec![(id, 1000 + (u128::max_value() - 1000) / 4)],
+          vec![(id, 1000 + (u128::max_value() - 1000) / 4 + 1)],
         ),
         (
           OutPoint { txid, vout: 1 },
-          vec![(id, (u128::max_value() - 1000) / 4)],
+          vec![(id, (u128::max_value() - 1000) / 4 + 1)],
         ),
         (
           OutPoint { txid, vout: 2 },
-          vec![(id, (u128::max_value() - 1000) / 4)],
+          vec![(id, (u128::max_value() - 1000) / 4 + 1)],
         ),
         (
           OutPoint { txid, vout: 3 },
@@ -2924,15 +2924,15 @@ mod tests {
       [
         (
           OutPoint { txid, vout: 0 },
-          vec![(id, u128::max_value() / 4 + 3)],
+          vec![(id, u128::max_value() / 4 + 1)],
         ),
         (
           OutPoint { txid, vout: 1 },
-          vec![(id, u128::max_value() / 4)],
+          vec![(id, u128::max_value() / 4 + 1)],
         ),
         (
           OutPoint { txid, vout: 2 },
-          vec![(id, u128::max_value() / 4)],
+          vec![(id, u128::max_value() / 4 + 1)],
         ),
         (
           OutPoint { txid, vout: 3 },
@@ -3430,14 +3430,14 @@ mod tests {
             txid: txid1,
             vout: 0,
           },
-          vec![(id, u128::max_value() / 2)],
+          vec![(id, u128::max_value() / 2 + 1)],
         ),
         (
           OutPoint {
             txid: txid1,
             vout: 1,
           },
-          vec![(id, u128::max_value() / 2 + 1)],
+          vec![(id, u128::max_value() / 2)],
         ),
       ],
     );