Add Bitcoin Core test job to CI (#1191)

.github/workflows/ci.yaml

@@ -68,6 +68,7 @@ jobs:
       run: |
         sudo apt-get install ripgrep
         ./bin/forbid
+
   test:
     strategy:
       matrix:
@@ -91,3 +92,23 @@ jobs:
 
     - name: Test
       run: cargo test --all
+
+  core:
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v3
+
+    - name: Install Rust Toolchain Components
+      uses: actions-rs/toolchain@v1
+      with:
+        profile: minimal
+        toolchain: stable
+
+    - uses: Swatinem/rust-cache@v2
+
+    - name: Install Bitcoin Core
+      run: ./bin/install-bitcoin-core-linux
+
+    - name: Test
+      run: cargo test --all -- --ignored

bin/install-bitcoin-core-linux

@@ -0,0 +1,15 @@
+#!/usr/bin/env bash
+
+set -euxo pipefail
+
+version=24.0.1
+
+wget \
+  -O bitcoin.tar.gz \
+  https://bitcoincore.org/bin/bitcoin-core-$version/bitcoin-$version-x86_64-linux-gnu.tar.gz
+
+tar \
+  -xzvf bitcoin.tar.gz \
+  -C /usr/local/bin \
+  --strip-components 2 \
+  bitcoin-$version/bin/{bitcoin-cli,bitcoind}

deploy/setup

@@ -55,8 +55,7 @@ esac
 ufw --force enable
 
 if ! which bitcoind; then
-  wget -O bitcoin.tar.gz 'https://bitcoincore.org/bin/bitcoin-core-23.0/bitcoin-23.0-x86_64-linux-gnu.tar.gz'
-  tar -xzvf bitcoin.tar.gz -C /usr/local/bin --strip-components=2 "bitcoin-23.0/bin/bitcoin-cli" "bitcoin-23.0/bin/bitcoind"
+  ./bin/install-bitcoin-core-linux
 fi
 
 bitcoind --version

src/subcommand/preview.rs

@@ -33,7 +33,7 @@ impl Preview {
           arg
         })
         .arg("-regtest")
-        .arg("-txindex=1")
+        .arg("-txindex")
         .arg("-listen=0")
         .arg(format!("-rpcport={rpc_port}"))
         .spawn()

tests/preview.rs → tests/core.rs

@@ -1,26 +1,29 @@
 use super::*;
 
+struct KillOnDrop(std::process::Child);
+
+impl Drop for KillOnDrop {
+  fn drop(&mut self) {
+    self.0.kill().unwrap()
+  }
+}
+
 #[test]
 #[ignore]
-fn run() {
-  let rpc_server = test_bitcoincore_rpc::spawn();
-
+fn preview() {
   let port = TcpListener::bind("127.0.0.1:0")
     .unwrap()
     .local_addr()
     .unwrap()
     .port();
 
-  let builder = CommandBuilder::new(format!("preview --http-port {port} foo.txt"))
-    .rpc_server(&rpc_server)
-    .write("foo.txt", "TEST_INSCRIPTION");
-
-  let mut command = builder.command();
+  let builder =
+    CommandBuilder::new(format!("preview --http-port {port} foo.txt")).write("foo.txt", "foo");
 
-  let mut child = command.spawn().unwrap();
+  let _child = KillOnDrop(builder.command().spawn().unwrap());
 
   for attempt in 0.. {
-    if let Ok(response) = reqwest::blocking::get(format!("http://localhost:{port}/status")) {
+    if let Ok(response) = reqwest::blocking::get(format!("http://127.0.0.1:{port}/status")) {
       if response.status() == 200 {
         assert_eq!(response.text().unwrap(), "OK");
         break;
@@ -35,12 +38,10 @@ fn run() {
   }
 
   assert!(
-    reqwest::blocking::get(format!("http://localhost:{port}/inscriptions"))
+    reqwest::blocking::get(format!("http://127.0.0.1:{port}/inscriptions"))
       .unwrap()
       .text()
       .unwrap()
-      .contains("TEST_INSCRIPTION")
+      .contains("<a href=/inscription/")
   );
-
-  child.kill().unwrap();
 }

tests/lib.rs

@@ -70,14 +70,14 @@ fn create_wallet(rpc_server: &test_bitcoincore_rpc::Handle) {
 }
 
 mod command_builder;
+mod core;
 mod epochs;
 mod expected;
 mod find;
 mod index;
 mod info;
 mod list;
 mod parse;
-mod preview;
 mod server;
 mod subsidy;
 mod supply;