Add error when a satpoint's offset exceeds the size of its output (#1857

)

Co-authored-by: Greg Martin <gm7t2@gmail.com>
Co-authored-by: raphjaph <raphjaph@protonmail.com>

src/subcommand/wallet/transaction_builder.rs

@@ -50,6 +50,7 @@ pub enum Error {
   },
   NotEnoughCardinalUtxos,
   NotInWallet(SatPoint),
+  OutOfRange(SatPoint, u64),
   UtxoContainsAdditionalInscription {
     outgoing_satpoint: SatPoint,
     inscribed_satpoint: SatPoint,
@@ -72,6 +73,7 @@ impl fmt::Display for Error {
         dust_value,
       } => write!(f, "output value is below dust value: {output_value} < {dust_value}"),
       Error::NotInWallet(outgoing_satpoint) => write!(f, "outgoing satpoint {outgoing_satpoint} not in wallet"),
+      Error::OutOfRange(outgoing_satpoint, maximum) => write!(f, "outgoing satpoint {outgoing_satpoint} offset higher than maximum {maximum}"),
       Error::NotEnoughCardinalUtxos => write!(
         f,
         "wallet does not contain enough cardinal UTXOs, please add additional funds to wallet."
@@ -227,6 +229,10 @@ impl TransactionBuilder {
       .get(&self.outgoing.outpoint)
       .ok_or(Error::NotInWallet(self.outgoing))?;
 
+    if self.outgoing.offset >= amount.to_sat() {
+      return Err(Error::OutOfRange(self.outgoing, amount.to_sat() - 1));
+    }
+
     self.utxos.remove(&self.outgoing.outpoint);
     self.inputs.push(self.outgoing.outpoint);
     self.outputs.push((self.recipient.clone(), amount));