Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegator/delegate content type mismatch #3055

Closed
arik-so opened this issue Jan 27, 2024 · 8 comments · Fixed by #3289
Closed

Delegator/delegate content type mismatch #3055

arik-so opened this issue Jan 27, 2024 · 8 comments · Fixed by #3289
Labels

Comments

@arik-so
Copy link
Contributor

arik-so commented Jan 27, 2024

When an inscription has a delegate, the content and preview endpoints are served with the delegate's mime type, as one would expect.

However, the delegating inscription's details page shows the mime type corresponding to the inscription itself which, while technically correct, doesn't tell the whole tale. It might be prudent to show the mime type of the inscription whose content is actually being returned, possibly alongside the inscription's own mime type.

@arik-so
Copy link
Contributor Author

arik-so commented Jan 27, 2024

I believe the same situation might also apply to the encoding field.

@raphjaph raphjaph added the bug label Feb 12, 2024
@raphjaph raphjaph added this to Tracker Feb 12, 2024
@gmart7t2
Copy link
Contributor

Is it safe to inscribe delegate inscriptions with no body, content type, or content encoding tags, and rely on those 3 things being picked up from the inscription that is pointed to by the delegate tag?

@gmart7t2
Copy link
Contributor

I notice that the master branch currently requires a file to be specified when making a delegated inscription, and includes that body in the envelope. This seems like a bug maybe?

@arik-so
Copy link
Contributor Author

arik-so commented Feb 16, 2024

@gmart7t2 it is perfectly safe to create inscriptions that contain neither body nor MIME type. They will work perfectly fine just containing the delegation instructions.

@gmart7t2
Copy link
Contributor

@gmart7t2 it is perfectly safe to create inscriptions that contain neither body nor MIME type

I know it works for now. I am wondering if it will continue to work going forward

@arik-so
Copy link
Contributor Author

arik-so commented Feb 16, 2024

I don't see a reason why not, especially considering the comments on #3027.

@gmart7t2
Copy link
Contributor

I've noticed that omitting the content type causes magic eden not to be able to display html inscriptions

@arik-so
Copy link
Contributor Author

arik-so commented Mar 28, 2024

Yes, that's why we now introduced an effective_content_type field in the API instead that they should be able to switch to to make it work seamlessly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants