Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return effective content type in JSON API. #3289

Merged
merged 6 commits into from
Mar 27, 2024

Conversation

arik-so
Copy link
Contributor

@arik-so arik-so commented Mar 14, 2024

For inscriptions with delegates, the content type of the underlying delegate should be exposed. Fixes #3055.

@arik-so arik-so force-pushed the effective-content-type branch 2 times, most recently from c77048c to b20c55f Compare March 14, 2024 21:54
@arik-so
Copy link
Contributor Author

arik-so commented Mar 15, 2024

One thing to note is that content-encoding could fall in a similar scenario. It might make more sense to return the delegate's mime type and content encoding, and perhaps create a separate field called direct/envelope/self (ask @casey for better nomenclature suggestions) which would have fields content_type and content_encoding that are the raw values in directly in the delegating inscription's envelope.

@arik-so arik-so force-pushed the effective-content-type branch from b20c55f to e08044a Compare March 15, 2024 01:07
@arik-so arik-so force-pushed the effective-content-type branch from e08044a to 70a12e8 Compare March 16, 2024 16:16
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raphjaph raphjaph enabled auto-merge (squash) March 27, 2024 22:02
@raphjaph raphjaph merged commit 0ed85a9 into ordinals:master Mar 27, 2024
5 checks passed
@arik-so arik-so deleted the effective-content-type branch March 27, 2024 22:07
vuviettai pushed a commit to codelight-co/runebeta_ord that referenced this pull request Mar 28, 2024
harutyunaraci pushed a commit to brc721-core/ord that referenced this pull request Mar 30, 2024
harutyunaraci added a commit to brc721-core/ord that referenced this pull request Apr 2, 2024
harutyunaraci pushed a commit to brc721-core/ord that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delegator/delegate content type mismatch
2 participants