Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a two-element array instead of a vec for change addresses #1281

Merged
merged 16 commits into from
Jan 19, 2023

Conversation

casey
Copy link
Collaborator

@casey casey commented Jan 18, 2023

This also broke the fuzz target, so I integrated it with the rest of the workspace, so it should get checked for syntax errors on CI.

@casey casey requested a review from raphjaph January 18, 2023 20:30
casey added 5 commits January 18, 2023 16:36

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@casey casey force-pushed the change-address-array branch from 0e72925 to a9cd19b Compare January 19, 2023 01:59
Dust {
output_value: Amount,
dust_value: Amount,
},
ValueOverflow,
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Target::Exact -> Target::TryExact ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something to reflect that a non exact value can happen in some edge case like in this PR

@@ -19,7 +19,7 @@ jobs:
docs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for the downgrade?

Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. other than a couple questions

@casey casey enabled auto-merge (squash) January 19, 2023 18:15
@casey casey merged commit 44ce258 into master Jan 19, 2023
@casey casey deleted the change-address-array branch January 19, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants