Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use JSON for all command output #1390

Closed
wants to merge 4 commits into from
Closed

Use JSON for all command output #1390

wants to merge 4 commits into from

Conversation

casey
Copy link
Collaborator

@casey casey commented Jan 26, 2023

No description provided.

rot13maxi
rot13maxi approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@rot13maxi rot13maxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is gonna be great

src/arguments.rs
@@ -10,7 +10,7 @@ pub(crate) struct Arguments {
}

impl Arguments {
pub(crate) fn run(self) -> Result {
pub(crate) fn run(self) -> Result<Box<dyn Output>> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooooooh. we're at that stage of the project :)

@casey casey mentioned this pull request Aug 22, 2023
Merged
@casey casey closed this Aug 22, 2023
@casey casey deleted the all-json branch September 5, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rot13maxi rot13maxi rot13maxi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casey @rot13maxi