Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add muted and autoplay to video tag in inscription iframe. #1420

Merged
merged 5 commits into from
Feb 1, 2023

Conversation

cryptoquick
Copy link
Contributor

Test it on this inscription:
f0ca46441f430b616e280377dee5d0a6e303db1de4d6f9da2389057f69427a41i0

Also, pardon my autoformatter, I just realized it made some changes to the HTML. Let me know if you'd like that noise removed.

@casey
Copy link
Collaborator

casey commented Feb 1, 2023

Nice! I think this a good change. Can you remove the changes from the auto-formatter?

Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See commit above.

@cryptoquick cryptoquick requested a review from casey February 1, 2023 01:04
@casey
Copy link
Collaborator

casey commented Feb 1, 2023

Nice, LGTM!

@casey casey enabled auto-merge (squash) February 1, 2023 23:14
@casey casey merged commit 1313d4b into ordinals:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants