Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove passing config file in ord service file #1697

Merged
merged 7 commits into from
Feb 17, 2023

Conversation

terror
Copy link
Contributor

@terror terror commented Feb 12, 2023

Fixes #1665

@terror terror changed the title Remove passing config file in service file Remove passing config file in ord service file Feb 12, 2023
@casey
Copy link
Collaborator

casey commented Feb 13, 2023

We need this config on ordinals.com, so we can't remove it.

Should we can make ord take a --config-dir option?

If this flag is passed, ord will look in that dir for ord.yaml, and if it doesn't find it, just not load any config. Then, we can put ord.yaml in a dir that already exist, like /var/lib/ord, and for users without it ord will not complain.

@terror
Copy link
Contributor Author

terror commented Feb 13, 2023

We need this config on ordinals.com, so we can't remove it.

Should we can make ord take a --config-dir option?

If this flag is passed, ord will look in that dir for ord.yaml, and if it doesn't find it, just not load any config. Then, we can put ord.yaml in a dir that already exist, like /var/lib/ord, and for users without it ord will not complain.

Yah that sounds good to me.

@raphjaph raphjaph merged commit f473aa6 into ordinals:master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing ord.yaml config file in ord.service causes error on deploy without manual intervention
3 participants