-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfile
to build Docker image
#1751
Conversation
Have you tried https://github.com/LukeMathWalker/cargo-chef? It will make subsequent builds much faster. I recommend using it for the dockerfile. |
This looks like a great start! One thing we are going to have to figure out is the best way to pass in parameters for RPC host, network (mainnet, regtest, etc) data directory, etc. Looking at how this is done for We might want to do something similar for |
An example service within a
|
hey @nevets963 , I foolishly did not search for Dockerfile PRs before making mine, and also submitted a PR for a dockerfile which generates a smaller docker image, (https://github.com/casey/ord/pull/1765) and was wondering what you thought. I am happy to close my PR if it's not interesting. My docker image is 28MB and yours is 104MB, but likely more usable. |
I would prefer a smaller image. But your PR does not include any README @magicniko |
I want to wait until we have a minimal dockerfile, that people find useful, before starting to dive into docker compose, and adding more features. We created a PR with a minimal |
This PR adds a
Dockerfile
so that a Docker image can be built and therefore makes it easier to runord
in different environments, OSes, etc.You can build the image using:
And run it using something like (on Umbrel):
Note: I would not suggest people run
ord
using the above command. This is simply what I used to test the Docker image.