Allow splitting merged inscriptions #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 13, 2023 14:03
We can safely send the last inscription from an output that contains multiple inscriptions. Iterate through the inscriptions in reverse order so that when attempting to send an inscription that isn't the last one in its output, the error message produced mentions the last inscription's location and inscription identifier.
… last inscription in its output
|
The lint failures go away after #1923. |
gmart7t2
force-pushed
the
allow-splitting-merged-inscriptions
branch
2 times, most recently
from
2386a4c to
7f921fb
Compare
raphjaph
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see a lot of users with multiple inscriptions merged into a single utxo.
Currently ord refuses to do anything with such utxos.
This pull request relaxes the condition on sending inscriptions and satpoints:
It is OK to send an inscription or satpoint from an output with multiple inscriptions in it as long as the satpoint being sent has no inscriptions after it, and also none within the dust limit before it.
As long as those conditions are met we can safely send the inscription or satpoint and the user can separate their merged inscriptions one by one, starting from the last in the output.
The error message when sending is not allowed has been modified to mention the last inscription in the output rather than the first to help guide the user to the one they need to send first.