-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read only Json API #2250
Read only Json API #2250
Conversation
_links aka HATEOAS make the API crawlable, it is better to have them then not have them. |
@Mathieu-Be just implemented the small changes I requested. Have a look if you agree with them. |
I'm going to leave out the Closes: #1662 |
Cool ! I haven't seen the changes you requested, did they get lost somewhere ? The Json struct looks nicer indeed. Want me to take a stab at the other endpoints ? |
I reviewed them above. Maybe they are collapsed (grey box)?
That would be great! But before you start I think we should make the JSON endpoint configurable in this PR. Such that you have to pass a flag to activate it. Something like |
Before adding the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go!
Opening a new PR based on the work of @ynohtna92 on #2036.
I'm not super experienced in Rust so I'm opening the PR to get early feedback, only the
sat
endpoint is implemented as of now.I'm wondering if it is really necessary to have the exact same fields as the HTML response, is the
_links
section really necessary for example ?Also, I feel like there could be a better way to build the Json response, but if I change the
Serialize
impl ofSat
it is breaking other stuff, so not sure what to do here (maybe create aSatApiResponse
struct based onSat
?)