Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preview-markdown #2325

Merged
merged 19 commits into from
Sep 19, 2023
Merged

preview-markdown #2325

merged 19 commits into from
Sep 19, 2023

Conversation

elocremarc
Copy link
Contributor

@elocremarc elocremarc commented Aug 12, 2023

Markdown media type was added in 2206
This Pr is to add support for markdown viewing on the /inscription and /preview page using the JS library marked It sanitizes the output HTML with DOMpurify
Recursive links and images are achievable in markdown files with.

[link](/content/<inscriptionId>)
![alt tag](/content/<inscriptionId>)

@elocremarc elocremarc force-pushed the recursive-markdown branch 2 times, most recently from 4af9f36 to 930de2e Compare September 4, 2023 07:12
@raphjaph
Copy link
Collaborator

raphjaph commented Sep 5, 2023

Let us know when this is ready to review

@elocremarc elocremarc marked this pull request as ready for review September 6, 2023 05:32
@elocremarc
Copy link
Contributor Author

@raphjaph Its ready.

@@ -0,0 +1,6 @@
import { marked } from 'https://cdn.jsdelivr.net/npm/marked@8.0.0/+esm'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use version 9

Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@casey casey enabled auto-merge (squash) September 19, 2023 18:28
@casey casey merged commit 89c3a74 into ordinals:master Sep 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants