-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preview-markdown #2325
Merged
Merged
preview-markdown #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elocremarc
force-pushed
the
recursive-markdown
branch
2 times, most recently
from
September 4, 2023 07:12
4af9f36
to
930de2e
Compare
added Dompurify, Marked working
elocremarc
force-pushed
the
recursive-markdown
branch
from
September 5, 2023 00:07
41b1f4c
to
5382ab6
Compare
Let us know when this is ready to review |
@raphjaph Its ready. |
raphjaph
reviewed
Sep 19, 2023
static/preview-markdown.js
Outdated
@@ -0,0 +1,6 @@ | |||
import { marked } from 'https://cdn.jsdelivr.net/npm/marked@8.0.0/+esm' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use version 9
raphjaph
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Markdown media type was added in 2206
This Pr is to add support for markdown viewing on the
/inscription
and/preview
page using the JS library marked It sanitizes the output HTML with DOMpurifyRecursive links and images are achievable in markdown files with.