Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Spanish(ES) #2338

Closed
wants to merge 1 commit into from
Closed

Documentation Spanish(ES) #2338

wants to merge 1 commit into from

Conversation

NNull13
Copy link

@NNull13 NNull13 commented Aug 19, 2023

Hello :D

@NNull13
Copy link
Author

NNull13 commented Aug 19, 2023

@raphjaph
Copy link
Collaborator

This is a great start but unfortunately this is not in the correct format for #2385. You can view how the docs look with mdbook serve docs --open. It should have a language switch button on the top right like seen here: https://google.github.io/comprehensive-rust/index.html

@Isabelfoxenduke
Copy link

This is a great start but unfortunately this is not in the correct format for #2385. You can view how the docs look with mdbook serve docs --open. It should have a language switch button on the top right like seen here: https://google.github.io/comprehensive-rust/index.html

Thanks for input Raph!

@Isabelfoxenduke
Copy link

This is a great start but unfortunately this is not in the correct format for #2385. You can view how the docs look with mdbook serve docs --open. It should have a language switch button on the top right like seen here: https://google.github.io/comprehensive-rust/index.html

Hi Raph - just for clarity - does this mean it is not possible to merge translation PRs until the mdbook language switch feature is implemented?

@raphjaph
Copy link
Collaborator

raphjaph commented Aug 30, 2023

I'm working on that now, will merge that today #2403

1 similar comment
@raphjaph
Copy link
Collaborator

raphjaph commented Aug 30, 2023

I'm working on that now, will merge that today #2403

@raphjaph
Copy link
Collaborator

I just merged #2403, so have a look at the updated README for instructions.

1 similar comment
@raphjaph
Copy link
Collaborator

I just merged #2403, so have a look at the updated README for instructions.

@raphjaph
Copy link
Collaborator

Thanks but we decided to go with this translation: #2448

@raphjaph raphjaph closed this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants