-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handbook Japanese and update ZH with Provenance section #2426
Conversation
Add Language Button "Japanese Version"
update ja.po
I'm having trouble building the the book. We're you able to build it properly? |
I can check the error info by tomorrow and run locally before commit |
fix format error ja.po ,local run successfully
Local run successfully after fix the typo and format error. |
To Update your translation version of Handbook, #2427 here is my opration cmds @ordinaHO
3,Run msgmerge, xx.po is your language version; this will allow the po file updated with the newest orignal version;
4,Find #, fuzzy ; i18n using "fuzzy" tag to mark those are newly edited ; 5,Do the transaltion works ; 6,Run mdbook cmd , here is zh example:
7,check everything is ok , then commit and open the PR to the github. |
Hi @DrJingLee , correct i spend sometime yesterday to check out the details! so far i think that adding <div dir="rtl"> command in my translation is making some mistakes as i used Poedit to move my original translation with the new format #2422 . |
Do you think its a good idea to generate the newest .pot file on the github every time when the oringinal book updated. @raphjaph so other people can just download the newest version and work on it if they don't have the local mdbook environment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but watch out not to check in files ending with ~
or .pot
files. I've removed them
I think to properly translate you should download the mdbook things but we should definitley add the commands that you need to run to the README under the Translations header. Would be great if you could open a seperate PR for that! |
update with ja.po ;
add language botton "日本語版"