Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview Code Syntax Highlighting #2471

Merged
merged 7 commits into from
Sep 30, 2023

Conversation

elocremarc
Copy link
Contributor

@elocremarc elocremarc commented Sep 25, 2023

Added highlight JS to format and syntax highlight code in the preview. JS, JSON, CSS and YAML. Can be used if other code filetypes are added.
eh_s2W5y

@elocremarc elocremarc marked this pull request as ready for review September 25, 2023 01:22
@elocremarc elocremarc force-pushed the syntax-code-highlight branch from 43024c2 to f537d04 Compare September 25, 2023 02:20
static/preview-code.css Outdated Show resolved Hide resolved
static/preview-code.css Outdated Show resolved Hide resolved
static/preview-code.js Outdated Show resolved Hide resolved
static/preview-code.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, other than some small things

@elocremarc
Copy link
Contributor Author

Looks good, other than some small things

Should be gtg!

@elocremarc elocremarc force-pushed the syntax-code-highlight branch from 8e42b7f to 4a1d3ce Compare September 28, 2023 10:56
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Bit of a pain that we have to import all languages explicitly but I think it makes sense for now to keep the bundle small.

@raphjaph raphjaph enabled auto-merge (squash) September 30, 2023 20:49
@raphjaph raphjaph merged commit 1e47933 into ordinals:master Sep 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants