Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile and docker-compose.yml #2691

Closed
wants to merge 7 commits into from
Closed

Conversation

bensig
Copy link

@bensig bensig commented Nov 17, 2023

This is a simple way to add docker support using a small docker image (ubuntu/latest) and installing the latest ord release using install.sh instead of building from source which uses a much bigger image.

Paths in docker-compose.yml can be updated to run on OS X, or in a custom path instead of /ordinals - for example if you prefer /var/local/ord or the more bitcoiny ~/.ord.

Can be easily run with:

docker-compose up -d

@bensig
Copy link
Author

bensig commented Nov 17, 2023

Updated docker-compose.yml to include default paths for ord index data in each OS

@raphjaph
Copy link
Collaborator

install.sh doesn't seem to work properly inside a docker image. Maybe we should build from source?

I'm on a Mac and getting this:

 [7/7] RUN ./install.sh --to /ordinals:
#10 0.643 install.sh: Could not determine target from output of `uname -m`-`uname -s`, please use `--target`: aarch64-Linux

@casey
Copy link
Collaborator

casey commented Nov 30, 2023

I want to wait until we have a minimal dockerfile, that people find useful, before starting to dive into docker compose, and adding more features.

We created a PR with a minimal Dockerfile, which still has issues: #2786

@casey casey closed this Nov 30, 2023
@bensig
Copy link
Author

bensig commented Dec 1, 2023

That minimum Dockerfile has a huge image for building rust. This Dockerfile uses a smaller image which was chosen based on the comments there. @raphjaph I fixed the Dockerfile so that install.sh works correctly now.

@casey
Copy link
Collaborator

casey commented Dec 1, 2023

There are a couple issues:

  • ubuntu-latest is a large base image that isn't necessary for running ord. I'd like to use a minimal image for actually running ord.
  • We want to build from source, not install a prebuilt binary, so the builder does need to include the necessary tools to build ord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants