Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserve runes AAAAAAAAAAAAAAAAAAAAAAAAAAA and above #2831

Merged
merged 14 commits into from
Dec 14, 2023

Conversation

casey
Copy link
Collaborator

@casey casey commented Dec 8, 2023

No description provided.

@casey casey requested a review from raphjaph December 8, 2023 01:43
@casey casey marked this pull request as draft December 8, 2023 01:56
@casey casey marked this pull request as ready for review December 10, 2023 21:48
@casey
Copy link
Collaborator Author

casey commented Dec 10, 2023

@raphjaph This is ready for review.

raphjaph and others added 3 commits December 11, 2023 23:49

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still some details I don't understand.

src/index/updater/rune_updater.rs Show resolved Hide resolved
src/runes.rs Outdated Show resolved Hide resolved
src/runes.rs Show resolved Hide resolved
src/runes/runestone.rs Outdated Show resolved Hide resolved
src/runes/runestone.rs Show resolved Hide resolved

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ordinalOS
Copy link

ordinalOS commented Dec 12, 2023

struct Focus {
    runes: u32,
    charmed_sats: u32,
}

impl Focus {
    // As the alchemist turns lead to gold.
    fn transmute(&mut self) {
        self.charmed_sats += self.runes;
        self.runes = 0;
        println!("Transmutation complete: {} charmed sats", self.charmed_sats);
    }
}

fn main() {
    let mut my_focus = Focus {
        runes: 10,
        charmed_sats: 5,
    };
    my_focus.transmute();
}

@casey casey linked an issue Dec 14, 2023 that may be closed by this pull request
@casey casey enabled auto-merge (squash) December 14, 2023 03:55
@casey casey merged commit cfc20c0 into ordinals:master Dec 14, 2023
6 checks passed
@casey casey deleted the reserve-runes branch December 14, 2023 03:58
@t4t5
Copy link

t4t5 commented Feb 9, 2024

What's the reason for reserving these runes? Couldn't figure it out from the runestone repo either: casey/runestone#116

@raphjaph
Copy link
Collaborator

raphjaph commented Feb 9, 2024

@casey should really start writing dome docs ;)

If I remember correctly an etching may not specify a name and will then get a rune name assigned from this range. This is for when you don't care about the name and just want to issue a rune.

@t4t5
Copy link

t4t5 commented Feb 9, 2024

@casey should really start writing dome docs ;)

If I remember correctly an etching may not specify a name and will then get a rune name assigned from this range. This is for when you don't care about the name and just want to issue a rune.

Ahh that makes sense! Cool feature. Thank you @raphjaph! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reserve range of runes for sequential allocation
4 participants