Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index transactions #2885

Merged
merged 3 commits into from
Dec 25, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions deploy/ord.service
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ ExecStart=/usr/local/bin/ord \
--data-dir /var/lib/ord \
--index-runes \
--index-sats \
--index-transactions \
server \
--acme-contact mailto:casey@rodarmor.com \
--csp-origin https://ordinals.com \
Expand Down
111 changes: 72 additions & 39 deletions src/index.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ use {
log::log_enabled,
redb::{
Database, DatabaseError, MultimapTable, MultimapTableDefinition, MultimapTableHandle,
ReadableMultimapTable, ReadableTable, RedbKey, RedbValue, StorageError, Table, TableDefinition,
TableHandle, WriteTransaction,
ReadOnlyTable, ReadableMultimapTable, ReadableTable, RedbKey, RedbValue, StorageError, Table,
TableDefinition, TableHandle, WriteTransaction,
},
std::{
collections::{BTreeSet, HashMap},
Expand Down Expand Up @@ -75,6 +75,7 @@ define_table! { SEQUENCE_NUMBER_TO_RUNE_ID, u32, RuneIdValue }
define_table! { SEQUENCE_NUMBER_TO_SATPOINT, u32, &SatPointValue }
define_table! { STATISTIC_TO_COUNT, u64, u64 }
define_table! { TRANSACTION_ID_TO_RUNE, &TxidValue, u128 }
define_table! { TRANSACTION_ID_TO_TRANSACTION, &TxidValue, &[u8] }
define_table! { WRITE_TRANSACTION_STARTING_BLOCK_COUNT_TO_TIMESTAMP, u32, u128 }

#[derive(Debug, PartialEq)]
Expand All @@ -97,6 +98,7 @@ pub(crate) enum Statistic {
Runes,
SatRanges,
UnboundInscriptions,
IndexTransactions,
}

impl Statistic {
Expand Down Expand Up @@ -195,6 +197,7 @@ pub struct Index {
height_limit: Option<u32>,
index_runes: bool,
index_sats: bool,
index_transactions: bool,
options: Options,
path: PathBuf,
started: DateTime<Utc>,
Expand Down Expand Up @@ -237,6 +240,7 @@ impl Index {

let index_runes;
let index_sats;
let index_transactions;

let index_path = path.clone();
let once = Once::new();
Expand All @@ -252,40 +256,32 @@ impl Index {
Ok(database) => {
{
let tx = database.begin_read()?;
let schema_version = tx
.open_table(STATISTIC_TO_COUNT)?
let statistics = tx.open_table(STATISTIC_TO_COUNT)?;

let schema_version = statistics
.get(&Statistic::Schema.key())?
.map(|x| x.value())
.unwrap_or(0);

match schema_version.cmp(&SCHEMA_VERSION) {
cmp::Ordering::Less =>
bail!(
"index at `{}` appears to have been built with an older, incompatible version of ord, consider deleting and rebuilding the index: index schema {schema_version}, ord schema {SCHEMA_VERSION}",
path.display()
),
cmp::Ordering::Greater =>
bail!(
"index at `{}` appears to have been built with a newer, incompatible version of ord, consider updating ord: index schema {schema_version}, ord schema {SCHEMA_VERSION}",
path.display()
),
cmp::Ordering::Equal => {
cmp::Ordering::Less =>
bail!(
"index at `{}` appears to have been built with an older, incompatible version of ord, consider deleting and rebuilding the index: index schema {schema_version}, ord schema {SCHEMA_VERSION}",
path.display()
),
cmp::Ordering::Greater =>
bail!(
"index at `{}` appears to have been built with a newer, incompatible version of ord, consider updating ord: index schema {schema_version}, ord schema {SCHEMA_VERSION}",
path.display()
),
cmp::Ordering::Equal => {
}
}
}

let statistics = tx.open_table(STATISTIC_TO_COUNT)?;

index_runes = statistics
.get(&Statistic::IndexRunes.key())?
.unwrap()
.value()
!= 0;

index_sats = statistics
.get(&Statistic::IndexSats.key())?
.unwrap()
.value()
!= 0;
index_runes = Self::is_statistic_set(&statistics, Statistic::IndexRunes)?;
index_sats = Self::is_statistic_set(&statistics, Statistic::IndexSats)?;
index_transactions = Self::is_statistic_set(&statistics, Statistic::IndexTransactions)?;
}

database
Expand Down Expand Up @@ -330,15 +326,12 @@ impl Index {

index_runes = options.index_runes();
index_sats = options.index_sats;
index_transactions = options.index_transactions;

statistics.insert(
&Statistic::IndexRunes.key(),
&u64::from(index_runes),
)?;

statistics.insert(&Statistic::IndexSats.key(), &u64::from(index_sats))?;

statistics.insert(&Statistic::Schema.key(), &SCHEMA_VERSION)?;
Self::set_statistic(&mut statistics, Statistic::IndexRunes, u64::from(index_runes))?;
Self::set_statistic(&mut statistics, Statistic::IndexSats, u64::from(index_sats))?;
Self::set_statistic(&mut statistics, Statistic::IndexSats, u64::from(index_transactions))?;
Self::set_statistic(&mut statistics, Statistic::Schema, SCHEMA_VERSION)?;
}

tx.commit()?;
Expand All @@ -361,6 +354,7 @@ impl Index {
height_limit: options.height_limit,
index_runes,
index_sats,
index_transactions,
options: options.clone(),
path,
started: Utc::now(),
Expand Down Expand Up @@ -610,6 +604,12 @@ impl Index {
insert_table_info(&mut tables, &wtx, total_bytes, SEQUENCE_NUMBER_TO_SATPOINT);
insert_table_info(&mut tables, &wtx, total_bytes, STATISTIC_TO_COUNT);
insert_table_info(&mut tables, &wtx, total_bytes, TRANSACTION_ID_TO_RUNE);
insert_table_info(
&mut tables,
&wtx,
total_bytes,
TRANSACTION_ID_TO_TRANSACTION,
);
insert_table_info(
&mut tables,
&wtx,
Expand Down Expand Up @@ -792,6 +792,28 @@ impl Index {
Ok(())
}

pub(crate) fn set_statistic(
statistics: &mut Table<u64, u64>,
statistic: Statistic,
value: u64,
) -> Result<()> {
statistics.insert(&statistic.key(), &value)?;
Ok(())
}

pub(crate) fn is_statistic_set(
statistics: &ReadOnlyTable<u64, u64>,
statistic: Statistic,
) -> Result<bool> {
Ok(
statistics
.get(&statistic.key())?
.map(|guard| guard.value())
.unwrap_or_default()
!= 0,
)
}

#[cfg(test)]
pub(crate) fn statistic(&self, statistic: Statistic) -> u64 {
self
Expand Down Expand Up @@ -1436,10 +1458,21 @@ impl Index {

pub(crate) fn get_transaction(&self, txid: Txid) -> Result<Option<Transaction>> {
if txid == self.genesis_block_coinbase_txid {
Ok(Some(self.genesis_block_coinbase_transaction.clone()))
} else {
self.client.get_raw_transaction(&txid, None).into_option()
return Ok(Some(self.genesis_block_coinbase_transaction.clone()));
}

if self.index_transactions {
if let Some(transaction) = self
.database
.begin_read()?
.open_table(TRANSACTION_ID_TO_TRANSACTION)?
.get(&txid.store())?
{
return Ok(Some(consensus::encode::deserialize(transaction.value())?));
}
}

self.client.get_raw_transaction(&txid, None).into_option()
}

pub(crate) fn get_transaction_blockhash(&self, txid: Txid) -> Result<Option<BlockHash>> {
Expand Down
13 changes: 13 additions & 0 deletions src/index/updater.rs
Original file line number Diff line number Diff line change
Expand Up @@ -602,6 +602,19 @@ impl<'index> Updater<'_> {
}
}

if index.index_transactions {
let mut transaction_id_to_transaction = wtx.open_table(TRANSACTION_ID_TO_TRANSACTION)?;

let mut buffer = Vec::new();
for (transaction, txid) in block.txdata {
transaction
.consensus_encode(&mut buffer)
.expect("in-memory writers don't error");
transaction_id_to_transaction.insert(&txid.store(), buffer.as_slice())?;
buffer.clear();
}
}

height_to_block_header.insert(&self.height, &block.header.store())?;

self.height += 1;
Expand Down
2 changes: 2 additions & 0 deletions src/options.rs
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ pub struct Options {
pub(crate) index_runes: bool,
#[arg(long, help = "Track location of all satoshis.")]
pub(crate) index_sats: bool,
#[arg(long, help = "Store transactions in index.")]
pub(crate) index_transactions: bool,
#[arg(
long,
short,
Expand Down
4 changes: 4 additions & 0 deletions test-bitcoincore-rpc/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,10 @@ impl Handle {
self.state.lock().unwrap()
}

pub fn clear_state(&self) {
self.state.lock().unwrap().clear();
}

pub fn wallets(&self) -> BTreeSet<String> {
self.state().wallets.clone()
}
Expand Down
4 changes: 4 additions & 0 deletions test-bitcoincore-rpc/src/state.rs
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ impl State {
}
}

pub(crate) fn clear(&mut self) {
*self = Self::new(self.network, self.version, self.fail_lock_unspent);
}

pub(crate) fn push_block(&mut self, subsidy: u64) -> Block {
let coinbase = Transaction {
version: 2,
Expand Down
27 changes: 27 additions & 0 deletions tests/server.rs
Original file line number Diff line number Diff line change
Expand Up @@ -459,3 +459,30 @@ fn sat_recursive_endpoints_without_sat_index_return_404() {
StatusCode::NOT_FOUND,
);
}

#[test]
fn transactions_are_stored_with_transaction_index() {
let rpc_server = test_bitcoincore_rpc::spawn();

rpc_server.mine_blocks(2);

let server = TestServer::spawn_with_args(&rpc_server, &["--index-transactions"]);

assert_eq!(
server
.request("/tx/f02151fda57850f323fa22b3d74c1e7039658ac788566677725fe682efb1fe3b")
.status(),
StatusCode::OK,
);

rpc_server.clear_state();

rpc_server.mine_blocks(1);

assert_eq!(
server
.request("/tx/f02151fda57850f323fa22b3d74c1e7039658ac788566677725fe682efb1fe3b")
.status(),
StatusCode::OK,
);
}
2 changes: 1 addition & 1 deletion tests/test_server.rs
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ impl TestServer {
for i in 0.. {
let response = reqwest::blocking::get(self.url().join("/blockcount").unwrap()).unwrap();
assert_eq!(response.status(), StatusCode::OK);
if response.text().unwrap().parse::<u64>().unwrap() == chain_block_count {
if response.text().unwrap().parse::<u64>().unwrap() >= chain_block_count {
break;
} else if i == 20 {
panic!("index failed to synchronize with chain");
Expand Down
Loading