Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary code #3348

Merged
merged 4 commits into from
Mar 23, 2024
Merged

Remove unnecessary code #3348

merged 4 commits into from
Mar 23, 2024

Conversation

lugondev
Copy link
Contributor

  1. Remove unnecessary parentheses
  2. Remove unnecessary path prefix

@casey casey enabled auto-merge (squash) March 23, 2024 18:21
@casey casey disabled auto-merge March 23, 2024 18:21
@casey casey enabled auto-merge (squash) March 23, 2024 18:21
@casey casey merged commit 418670c into ordinals:master Mar 23, 2024
5 checks passed
@casey
Copy link
Collaborator

casey commented Mar 23, 2024

I added Self back. We import the variants of Language and ImageRendering so Media::Table will be more readable. I otherwise don't really like to use enum variants directly.

@lugondev
Copy link
Contributor Author

I added Self back. We import the variants of Language and ImageRendering so Media::Table will be more readable. I otherwise don't really like to use enum variants directly.

thanks <3

@lugondev lugondev deleted the clean-code branch March 24, 2024 05:35
harutyunaraci pushed a commit to brc721-core/ord that referenced this pull request Mar 30, 2024
@lugondev @harutyunaraci
Cleanup (ordinals#3348)
6f77b24
@BrewTestBot BrewTestBot mentioned this pull request Mar 31, 2024
Merged
harutyunaraci added a commit to brc721-core/ord that referenced this pull request Apr 2, 2024
@harutyunaraci
Revert "Cleanup (ordinals#3348)"
0f28f9a 
This reverts commit 6f77b24.
harutyunaraci pushed a commit to brc721-core/ord that referenced this pull request Apr 2, 2024
@lugondev @harutyunaraci
Cleanup (ordinals#3348)
cb0982d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lugondev @casey