Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ord rune publish #637

Merged
merged 2 commits into from
Oct 11, 2022
Merged

Add ord rune publish #637

merged 2 commits into from
Oct 11, 2022

Conversation

casey
Copy link
Collaborator

@casey casey commented Oct 10, 2022 •
edited
Loading

  • ord rune publish with new returns created
  • /rune/HASH shows published rune
  • /rune/UNKNOWN_HASH returns error message and NOT FOUND
  • make sure hash is calculated on server
  • should /rune/HASH show the network, or is that implied?
  • ord rune publish with old returns OK
  • only allow runes with the correct network to be posted
  • mainnet is forbidden

@casey casey requested a review from raphjaph October 11, 2022 00:41
@casey
Copy link
Collaborator Author

casey commented Oct 11, 2022

@raphjaph This should be ready for review!

@casey casey enabled auto-merge (squash) October 11, 2022 17:44
@casey casey merged commit 7b47149 into master Oct 11, 2022
@casey casey deleted the rune branch October 11, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphjaph raphjaph raphjaph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casey @raphjaph