Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trio is now typed, no need for trio-typing #24

Merged
merged 5 commits into from
Jan 11, 2024

Conversation

mikenerone
Copy link
Contributor

trio-typing is generally a bit broken and causes type-checking troubles for users (e.g. me) when pulled in by tricycle. Also updated the support Python versions (3.7 EOL, long live 3.12).

@mikenerone
Copy link
Contributor Author

There are currently some typing warnings on a bunch of the start_soon() calls in the tests, but I'm failing to spot why the "expected" signature is so strict (accepting only a single positional arg?). I might just be tired. :P

@graingert
Copy link
Contributor

@mikenerone fixed by upgrading mypy #25

@mikenerone
Copy link
Contributor Author

@graingert Thanks! I was totally missing it being a mypy bug. I've pulled your commits into this PR.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d9226be) 100.00% compared to head (4ea9df8) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #24   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1312      1306    -6     
  Branches       216       216           
=========================================
- Hits          1312      1306    -6     
Flag Coverage Δ
3.10 99.92% <100.00%> (-0.01%) ⬇️
3.11 99.92% <100.00%> (-0.01%) ⬇️
3.12 99.92% <100.00%> (?)
3.12-dev ?
3.7 ?
3.8 99.92% <100.00%> (-0.01%) ⬇️
3.9 99.92% <100.00%> (-0.01%) ⬇️
Ubuntu 99.92% <100.00%> (-0.01%) ⬇️
Windows 99.92% <100.00%> (-0.01%) ⬇️
macOS 99.92% <100.00%> (-0.01%) ⬇️
pypy-3.8 99.30% <100.00%> (-0.01%) ⬇️
pypy-3.9 99.30% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oremanj
Copy link
Owner

oremanj commented Jan 11, 2024

macOS is still building on 3.7 which now fails. 3.13-dev seems broken, you can remove it from the matrix.

@oremanj oremanj merged commit 2736e5b into oremanj:master Jan 11, 2024
26 checks passed
@mikenerone mikenerone deleted the mikenerone/typed-trio branch February 9, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants