-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trio is now typed, no need for trio-typing #24
Conversation
There are currently some typing warnings on a bunch of the |
@mikenerone fixed by upgrading mypy #25 |
@graingert Thanks! I was totally missing it being a mypy bug. I've pulled your commits into this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 1312 1306 -6
Branches 216 216
=========================================
- Hits 1312 1306 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
macOS is still building on 3.7 which now fails. 3.13-dev seems broken, you can remove it from the matrix. |
trio-typing is generally a bit broken and causes type-checking troubles for users (e.g. me) when pulled in by tricycle. Also updated the support Python versions (3.7 EOL, long live 3.12).