Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cfn validate schema warnings #93

Merged
merged 2 commits into from
Sep 28, 2021
Merged

fix: cfn validate schema warnings #93

merged 2 commits into from
Sep 28, 2021

Conversation

readOnlyProperties cannot be specified by customers and should not overlap with writeOnlyProperties, createOnlyProperties, or required: {'/properties/ResourceId'}
Don't hardcode the aws partition in ARN patterns: ^arn:aws:securityhub:[A-Za-z0-9-]{1,64}:[0-9]{12}:action/custom/.+$

https://docs.aws.amazon.com/general/latest/gr/aws-arns-and-namespaces.html#arns-syntax
@PatMyron PatMyron merged commit 513737a into master Sep 28, 2021
@PatMyron PatMyron deleted the cfn-validate branch September 28, 2021 01:04
@PatMyron
Copy link
Contributor Author

arn:aws: ARN partition still hardcoded in handlers.ts code:
https://github.com/search?q=repo:org-formation/aws-resource-providers+arn:aws:+language:TypeScript

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant