Remove the flaw links when it can fallback to en-US in l10n

[awxiaoxian2020]

https://github.com/mdn/yari/blob/1cb12182f2aa524c1f9af4ec9eca4e238220f8b5/build/flaws/broken-links.js#L319

I think when we get a hint that there is a broken link. We should try to fix it. Otherwise, hint is less useful.

Use a unified localized link to facilitate maintenance. When there is a l10n of the content, jump to the l10n of the link, if not, jump to the English version. I think it's a good mechanism.
When the maintainers see that the localized link does not exist, they will not be able to add localized content in the short term. So I don't think this is a bug, just a good strategy that doesn't need hints.

[awxiaoxian2020]

Any response for this issue?

[bsmth]

Hi @awxiaoxian2020, thanks for opening the discussion. Pinging @mdn/core-dev :)

[caugner]

@mdn/localization-team-leads The OP suggests to remove the broken link flaw for cases where we can fallback to en-US. Does this make sense to you?

[cw118]

I personally think this makes sense. I might be wrong, but the fallback to en-US link flaw seems to encourage pointing links to the en-US page if its translation does not exist. This can make maintaining translated content more difficult if we have to replace these en-US links once the page is localized, especially when the links already automatically fall back to the English page and will point to the localized version when it is created, as expected.

Unless there are other uses for the flaw, I do not think it is needed.

[mfuji09]

I agree to remove reporting link flaws if they can be redirected to en-US pages. Because:

1. They are not flaws in the reported page.
2. They shouldn't be fixed not to be reported the flaw, as @cw118 said.
3. Also, if the pages linked to from the sidebar have not yet been translated, many flaws are reported that cannot be fixed immediately, covering up the flaws that should be fixed,
   For example, these flaws reported are due to lack localized pages linked in the sidebar:
   

The pages which haven't been translated yet are easily can be get, for example:

• getting diff between the language's and en-US contents
• via the localization dashboard (http://localhost:3000/xx/_translations/dashboard) or missing page.

[awxiaoxian2020]

So would anyone like to submit a PR to move this forward?

[yin1999]

I've created a PR for this: mdn/yari#9408. But we may also need to reorganize the repair logic for URL.

[yin1999]

Hey all. I think @awxiaoxian2020 created this discussion to address the flaw reporting in broken-links.js, and this has been resolved in mdn/yari#9408. While the screenshot provided by @mfuji09 shows that there are many missing localized page flaws (MacroBrokenLinkError caused by this) reported by the kuma macros. I think we should also remove the flaws reporting related to it. Let me know your thought :)