Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add version input variable #27

Merged
merged 12 commits into from
Aug 26, 2024
Merged

feat: add version input variable #27

merged 12 commits into from
Aug 26, 2024

Conversation

M0NsTeRRR
Copy link
Contributor

@M0NsTeRRR M0NsTeRRR commented Jul 8, 2024

The purpose of this PR is to allow setting the git-cliff release version without waiting to tag a new release for this action (and also pinning to a specific one).
Unfortunately, it's not possible to update FROM from an argument, so we have to use bash or javaScript. This PR also addresses issue #18, as there is no Docker image to build or to pull. I preferred to download the binary to speed up the process (instead of installing python and the associated package for example).

The old action took around 6 seconds due to the Docker build, whereas this one takes 0 seconds.

If we implement this, we can close #26 as it will no longer be needed.

@M0NsTeRRR
Copy link
Contributor Author

M0NsTeRRR commented Jul 8, 2024

@orhun you can test it with my fork with m0nsterrr/git-cliff-action@v1.0.0

@orhun
Copy link
Owner

orhun commented Jul 29, 2024

Hey, thanks for the PR! The shell script is scary at first glance, can we possibly split them into different files? (e.g. install.sh & run.sh)

Also, this will require a major version bump if I'm not mistaking, right? (e.g. v4)

@M0NsTeRRR
Copy link
Contributor Author

Hey, thanks for the PR! The shell script is scary at first glance, can we possibly split them into different files? (e.g. install.sh & run.sh)

Also, this will require a major version bump if I'm not mistaking, right? (e.g. v4)

You're welcome. Yes, I agree...
After reading the documentation, I found that it is possible to include local GitHub Action files.
It should not be a breaking change as the user only manipulates input variables, but I'm not a GitHub Actions expert. 😊

@M0NsTeRRR
Copy link
Contributor Author

I hate bash 🥲

@M0NsTeRRR
Copy link
Contributor Author

You can test with m0nsterrr/git-cliff-action@v1.3.1

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I will test it thoroughly and merge it right after the new git-cliff release coming up :) Thanks!

README.md Outdated Show resolved Hide resolved
M0NsTeRRR and others added 3 commits July 31, 2024 08:15
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

I think I will go with v4, just to be safe :)

@orhun orhun merged commit 44415ff into orhun:main Aug 26, 2024
1 check passed
@M0NsTeRRR M0NsTeRRR deleted the feat/version branch August 26, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants