-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add version input variable #27
Conversation
@orhun you can test it with my fork with |
Hey, thanks for the PR! The shell script is scary at first glance, can we possibly split them into different files? (e.g. Also, this will require a major version bump if I'm not mistaking, right? (e.g. |
You're welcome. Yes, I agree... |
Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>
Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>
I hate bash 🥲 |
You can test with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I will test it thoroughly and merge it right after the new git-cliff
release coming up :) Thanks!
Co-authored-by: Orhun Parmaksız <orhunparmaksiz@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
I think I will go with v4
, just to be safe :)
The purpose of this PR is to allow setting the git-cliff release version without waiting to tag a new release for this action (and also pinning to a specific one).
Unfortunately, it's not possible to update
FROM
from an argument, so we have to use bash or javaScript. This PR also addresses issue #18, as there is no Docker image to build or to pull. I preferred to download the binary to speed up the process (instead of installing python and the associated package for example).The old action took around 6 seconds due to the Docker build, whereas this one takes 0 seconds.
If we implement this, we can close #26 as it will no longer be needed.