refactor(gitlab): clean up url encoding for GitLab

git-cliff-core/src/remote/gitlab.rs

@@ -6,7 +6,6 @@ use serde::{
 	Serialize,
 };
 use std::env;
-use urlencoding::encode;
 
 use super::*;
 
@@ -48,7 +47,12 @@ pub struct GitLabProject {
 
 impl RemoteEntry for GitLabProject {
 	fn url(_id: i64, api_url: &str, remote: &Remote, _page: i32) -> String {
-		format!("{}/projects/{}%2F{}", api_url, encode(remote.owner.as_str()), remote.repo)
+		format!(
+			"{}/projects/{}%2F{}",
+			api_url,
+			urlencoding::encode(remote.owner.as_str()),
+			remote.repo
+		)
 	}
 
 	fn buffer_size() -> usize {
@@ -290,17 +294,13 @@ impl GitLabClient {
 mod test {
 	use super::*;
 	use pretty_assertions::assert_eq;
-
-    fn test_remote_entry_url<R: RemoteEntry>(expects: &str) {
+
+	#[test]
+	fn gitlab_remote_encodes_owner() {
 		let remote = Remote::new("abc/def", "xyz1");
 		assert_eq!(
-			expects, 
-			R::url(1, "https://gitlab.test.com/api/v4", &remote, 0)
+			"https://gitlab.test.com/api/v4/projects/abc%2Fdef%2Fxyz1",
+			GitLabProject::url(1, "https://gitlab.test.com/api/v4", &remote, 0)
 		)
 	}
-
-	#[test]
-	fn it_url_encodes_slashes() {
-		test_remote_entry_url::<GitLabProject>("https://gitlab.test.com/api/v4/projects/abc%2Fdef%2Fxyz1")
-	}
 }

website/docs/integration/gitlab.md

@@ -63,7 +63,7 @@ GITLAB_TOKEN="***" git cliff --gitlab-repo "orhun/git-cliff"
 
 You can use the `GITLAB_API_URL` environment variable want to override the API URL. This is useful if you are using your own GitLab instance.
 
-When your project on your own Gitlab has one or many subgroups (e.g my.gitlab.com/myGroup/mySubgroup/myProject) set owner in the toml to "myGroup/mySubgroup" and repo to the repo name.
+When your project on your own GitLab has one or many subgroups (e.g my.gitlab.com/myGroup/mySubgroup/myProject) you don't need to URL encode the owner in the configuration. (i.e. simply use "myGroup/mySubgroup")
 
 :::