cmake: remove gcc version check for visibility support #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lchain#166) Signed-off-by: Johannes Meyer <johannes@intermodalics.eu>
|
#235 follows up on the visibility issue. |
meyerj
added a commit
to Intermodalics/rtt
that referenced
this pull request
Jun 11, 2018
cmake: remove gcc version check for visibility support
meyerj
added a commit
to Intermodalics/rtt
that referenced
this pull request
Jun 11, 2018
cmake: remove gcc version check for visibility support
meyerj
added a commit
to Intermodalics/rtt
that referenced
this pull request
Jun 11, 2018
cmake: remove gcc version check for visibility support
meyerj
added a commit
that referenced
this pull request
Nov 29, 2021
cmake: remove gcc version check for visibility support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gcc version check has been updated several times (#191, #154) in the past to support newer versions and involves a fragile compiler execution using
execute_process(). I think it's time to simply drop support for older versions that do not yet support visibility attributes, older than gcc 4.2 released in 2007, which introduced visibility support for types.Note that RTT does not set the default visibility to hidden on its own (by adding the
-fvisibility=hiddenoption) and all symbols are visible by default. Perhaps this option was even removed/commented accidentally during the refactoring in 72bc0bd.See also https://gcc.gnu.org/wiki/Visibility.
TODO:
-fvisibility=hiddencompile option