AclHelper: ensure $owners can be json_serialized to an array #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on OroCRM 4.2 and PHP 8.
Currently, when using ElasticSearch as a search engine, queries that contain an ACL ownership condition are generated incorrectly.
E.g.: this fragment:
... {"terms":{"oro_email_campaign_owner":{"0":76,"1":1,"2":2,"3":3 ...Should instead be serialized as:
... {"terms":{"oro_email_campaign_owner":[76, 1, 2, 3 ....This leads to ES rejecting the query because of a syntax error.
This PR ensures that the owner array is not keyed with strings, thus being wrongly json_serialized while producing an ES query.