Fix false positives on errors with different messages. #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
src/specs/test.spec.js
to run with either mocha or Jest. This was done to ensure that we can verify that our functional tests work properly with either framework. It could be part of the CI to run both sets of tests.assert.deepEqual
where all Errors are considered equal. This is a known and accepted issue as described here Comparing errors through deepEqual nodejs/node#3122Concerns:
deepEqual
check on Errors is naive, creating two "error" objects with a message and name property and comparing them. I'm concerned about browser compatibility with this. Each browser has different property names on Errors and we could run into problems if someone is testing this with jasmine or some other client side testing framework. We may consider creating a function to normalize error properties across the different browsers and node.