Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use Maven Annotations #15

Merged
merged 4 commits into from
Dec 30, 2014
Merged

Update to use Maven Annotations #15

merged 4 commits into from
Dec 30, 2014

Conversation

hazendaz
Copy link
Contributor

No description provided.

@hazendaz
Use maven annotations
2b580eb 
Upgrade to using java 5 annotations for maven as it is much cleaner.
Update assembly plugin
minor cleanup on formatting to be in sync.
@hazendaz
add .factorypath to gitignore.
d4bb1ce
@hazendaz
More build updates
c350c3e 
maven-plugin-api to 3.2.5
maven-plugin-descriptor to 2.2.1
maven-assembly-plugin to 2.5.3
maven-surefire-plugin to 2.18.1
junit to 4.12
lukaszlenart
lukaszlenart reviewed Dec 29, 2014
View reviewed changes
src/main/java/com/akathist/maven/plugins/launch4j/ClassPath.java
@@ -92,7 +88,7 @@ private void addToCp(List<String> cp, String cpStr) {
// Add all runtime dependencies as we need them to run the wrapped jar
dependencies.addAll(runtimeDependencies);

for (Object dependency : dependencies) {
for (Artifact dependency : dependencies) {
Artifact dep = (Artifact) dependency;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't needed anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not real clear here on what isn't necessary now. Method is called throughout code. Do you mean the cast to artifact? I think that is what you mean but not completely sure.

@lukaszlenart
Copy link
Collaborator

Looks good, few minor issues and I'm good :) Nice work!

@hazendaz
Minor feedback cleanup.
433830a 
Remove unnecessary artifact cast and use spacing similar to area of code
for runtimebits.
@lukaszlenart
Copy link
Collaborator

Let's rock!

lukaszlenart added a commit that referenced this pull request Dec 30, 2014
@lukaszlenart
Merge pull request #15 from hazendaz/master
e773e9c 
Update to use Maven Annotations
@lukaszlenart lukaszlenart merged commit e773e9c into orphan-oss:master Dec 30, 2014
@lukaszlenart
Copy link
Collaborator

Because of the org.eclipse.m2e plugin there is a lot of warnings now :(

[WARNING] The POM for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 is missing, no dependency information available
[WARNING] Failed to retrieve plugin descriptor for org.eclipse.m2e:lifecycle-mapping:1.0.0: Plugin org.eclipse.m2e:lifecycle-mapping:1.0.0 or one of its dependencies could not be resolved: Failure to find org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 in http://uk.maven.org/maven2/ was cached in the local repository, resolution will not be reattempted until the update interval of uk has elapsed or updates are forced
[WARNING] The POM for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 is missing, no dependency information available
[WARNING] Failed to retrieve plugin descriptor for org.eclipse.m2e:lifecycle-mapping:1.0.0: Plugin org.eclipse.m2e:lifecycle-mapping:1.0.0 or one of its dependencies could not be resolved: Failure to find org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 in http://uk.maven.org/maven2/ was cached in the local repository, resolution will not be reattempted until the update interval of uk has elapsed or updates are forced

@hazendaz
Copy link
Contributor Author

Very strange. I do not believe I have seen that one before as an issue. Have you tried deleting that item from your local .m2/repository and trying again? If that doesn't end up helping that plugin is 100% safe to delete. All it does more or less is remove other warnings about life cycle issues which in turn can be modified to ignore anyways in eclipse.

--- Original Message ---

From: "Lukasz Lenart" notifications@github.com
Sent: January 15, 2015 3:21 AM
To: "lukaszlenart/launch4j-maven-plugin" launch4j-maven-plugin@noreply.github.com
Cc: "Jeremy Landis" jeremylandis@hotmail.com
Subject: Re: [launch4j-maven-plugin] Update to use Maven Annotations (#15)

Because of the org.eclipse.m2e plugin there is a lot of warnings now :(

[WARNING] The POM for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 is missing, no dependency information available
[WARNING] Failed to retrieve plugin descriptor for org.eclipse.m2e:lifecycle-mapping:1.0.0: Plugin org.eclipse.m2e:lifecycle-mapping:1.0.0 or one of its dependencies could not be resolved: Failure to find org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 in http://uk.maven.org/maven2/ was cached in the local repository, resolution will not be reattempted until the update interval of uk has elapsed or updates are forced
[WARNING] The POM for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 is missing, no dependency information available
[WARNING] Failed to retrieve plugin descriptor for org.eclipse.m2e:lifecycle-mapping:1.0.0: Plugin org.eclipse.m2e:lifecycle-mapping:1.0.0 or one of its dependencies could not be resolved: Failure to find org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 in http://uk.maven.org/maven2/ was cached in the local repository, resolution will not be reattempted until the update interval of uk has elapsed or updates are forced

Reply to this email directly or view it on GitHub:
#15 (comment)

@lukaszlenart
Copy link
Collaborator

try mvn clean source:jar - it happens only during release

@hazendaz
Copy link
Contributor Author

This can be ignored but if you want to delve farther, I found this http://stackoverflow.com/questions/7905501/get-rid-of-pom-not-found-warning-for-org-eclipse-m2elifecycle-mapping

@lukaszlenart
Copy link
Collaborator

Thanks! Moved the plugin into a profile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hazendaz @lukaszlenart