-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default values for configuration, especially VersionInfo #205
Merged
lukaszlenart
merged 35 commits into
orphan-oss:master
from
koksyn:feature-default-params
Jan 6, 2023
Merged
Default values for configuration, especially VersionInfo #205
lukaszlenart
merged 35 commits into
orphan-oss:master
from
koksyn:feature-default-params
Jan 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub uses one of many kinds of Markdown syntaxes. In this one it does not display plain text inside angle brackets (like <any text>) in the headers, so we need to escape them. For details, please see the issue: microsoft/vscode#12491
koksyn
changed the title
Default values for configuration, especially VersionInfo
Draft: Default values for configuration, especially VersionInfo
Dec 29, 2022
koksyn
changed the title
Draft: Default values for configuration, especially VersionInfo
Default values for configuration, especially VersionInfo
Dec 30, 2022
lukaszlenart
requested changes
Jan 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, great tests 👏 - I left a few comments for consideration
src/main/java/com/akathist/maven/plugins/launch4j/VersionInfo.java
Outdated
Show resolved
Hide resolved
src/main/java/com/akathist/maven/plugins/launch4j/generators/CopyrightGenerator.java
Outdated
Show resolved
Hide resolved
src/main/java/com/akathist/maven/plugins/launch4j/generators/Launch4jFileVersionGenerator.java
Show resolved
Hide resolved
src/main/java/com/akathist/maven/plugins/launch4j/generators/Launch4jFileVersionGenerator.java
Show resolved
Hide resolved
src/main/java/com/akathist/maven/plugins/launch4j/generators/Launch4jFileVersionGenerator.java
Show resolved
Hide resolved
src/main/java/com/akathist/maven/plugins/launch4j/generators/Launch4jFileVersionGenerator.java
Outdated
Show resolved
Hide resolved
LGTM 🎉 or rather squash&merge ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version notes 2.3.0 - 2022-12-30
<VersionInfo>
, see Issue #98disableVersionInfoDefaults
parameter to be able to disable provided defaults[ERROR] Failed to execute goal com.akathist.maven.plugins.launch4j:launch4j-maven-plugin:2.3.0-SNAPSHOT:launch4j (l4j-gui) on project launch4j-demo: Cannot fill out VersionInfo by defaults: Please fill the missing configuration values. Error when trying to fulfill default value for VersionInfo parameter:'fileDescription' with formula params:'${project.description}'. -
Closes #98