Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sys-power/cpupower-gui #91

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Conversation

seven-mile
Copy link
Contributor

@seven-mile seven-mile commented Jan 7, 2024

sys-power/cpupower-gui has two issues

I'm not familiar with ebuild repo maintaince, feel free to fix if something wrong.

@seven-mile seven-mile changed the title Fix sys-power/ Fix sys-power/cpupower-gui Jan 7, 2024
@orsonteodoro
Copy link
Owner

orsonteodoro commented Jan 7, 2024

You are close.

  1. The use_libexec is not a standard global USE flag same goes with libexec.[2] The style guide prefers - over _.[1] Typically a USE flag is simple so just 1 word. One may change it to dbus or leave it as a local USE flag. Generally, global USE flag names are preferred over local names.
  2. The meson_use function from the meson.eclass accepts 2 args.[3] Arg1 is the USE flag. Arg2 is the build flag. If only 1 arg is provided, it will use it as both the USE flag and the build flag.

I will let you make the change to gain experience. If you prefer not to make change, I will merge the change(s) and fix it afterward.

References:
[1] https://dev.gentoo.org/~ulm/pms/head/pms.html#section-3.1.4
[2] https://www.gentoo.org/support/use-flags/
[3] https://github.com/gentoo-mirror/gentoo/blob/stable/eclass/meson.eclass#L254

@seven-mile
Copy link
Contributor Author

Thank you for reviewing! I pushed the fix and you can check it out.
The commit log is verbose now. Freely squash it if you like~

@orsonteodoro orsonteodoro merged commit f5a6d34 into orsonteodoro:master Jan 8, 2024
@orsonteodoro
Copy link
Owner

Thank you for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants