Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): fix filtering when table is not sorted #911

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

dauriata
Copy link
Contributor

Proposed Changes

Fixes table filtering when table is not yet sorted
currentSortColumn is undefined when the table is not sorted ( no defaultSort prop defined) and the property is accessed in handleFilter function throwing an error
Adding a safe guard in the function

Copy link

netlify bot commented Apr 27, 2024

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 71b7800
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/662d78285386120008f53008
😎 Deploy Preview https://deploy-preview-911--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 17.85%. Comparing base (484cfe8) to head (71b7800).
Report is 57 commits behind head on develop.

Files Patch % Lines
packages/oruga/src/components/table/Table.vue 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #911       +/-   ##
============================================
- Coverage    56.71%   17.85%   -38.86%     
============================================
  Files           30      292      +262     
  Lines         1511     7319     +5808     
  Branches       544     2095     +1551     
============================================
+ Hits           857     1307      +450     
- Misses         654     5061     +4407     
- Partials         0      951      +951     
Flag Coverage Δ
oruga-next 17.85% <0.00%> (-38.86%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek changed the title fix(table): Fix filtering when table is not sorted fix(table): fix filtering when table is not sorted Apr 28, 2024
@mlmoravek mlmoravek added enhancement Improvements to existing features and functionality bug Something isn't working labels Apr 28, 2024
@mlmoravek mlmoravek merged commit 10ee451 into oruga-ui:develop Apr 29, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Improvements to existing features and functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants