Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue or Design Document
A form cannot have two input fields with the same name. Unfortunately we need to also support express server-side rendering which does not include much JS on the client.
Due to the previous implementation only being in CSS and with limited browser support, this PR addresses those issues by implementing a strategy that works for both React and Express.
In the end we have more JS, but it's minimal and vanilla. We now never have more than 1 input field on the dom related to password and will only display the custom field for password entry. The visibility toggle has also been updated to be a
div
element with thedataset
property keeping the state for the visibility icon to swap via css.#116
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
Further comments