Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#754] Requester ID fix #756

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

vivshankar
Copy link
Contributor

The description of the problem is part of the #754 . This is not a breaking change.

Related Issue or Design Document

N/A

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

This is a minor change that has no impact to existing flows. It merely serves to be consistent with the auth code flow implementation and caters for cases highlighted in the Github issue.

@aeneasr
Copy link
Member

aeneasr commented Jul 17, 2023

Nice! Maybe add a test so this never regresses?

@vivshankar
Copy link
Contributor Author

@aeneasr Modified one of the refresh token flow tests

@mitar
Copy link
Contributor

mitar commented Jan 29, 2024

@vivshankar Care to refresh this PR with latest master?

@aeneasr aeneasr force-pushed the 754-refresh-token-requester-ID-fix branch from 450cdbe to 23b3ac5 Compare February 12, 2024 14:57
@aeneasr aeneasr merged commit 9b98b55 into ory:master Feb 13, 2024
5 checks passed
james-d-elliott pushed a commit to james-d-elliott/fosite that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants