Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for OIDC VC #758

Merged
merged 2 commits into from
Aug 7, 2023
Merged

feat: add support for OIDC VC #758

merged 2 commits into from
Aug 7, 2023

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Jul 17, 2023

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@hperl hperl requested a review from aeneasr as a code owner July 17, 2023 12:12
@hperl hperl self-assigned this Jul 17, 2023
@hperl hperl force-pushed the oidc-vc branch 2 times, most recently from 3407185 to 0b680d0 Compare July 19, 2023 11:53
@hperl hperl mentioned this pull request Jul 19, 2023
Merged
7 tasks
@hperl hperl force-pushed the oidc-vc branch 2 times, most recently from 91991bc to bc7e338 Compare July 24, 2023 10:59
aeneasr
aeneasr reviewed Jul 25, 2023
View reviewed changes
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got two questions - rest LGTM :)

handler/verifiable/handler.go Outdated Show resolved Hide resolved
handler/verifiable/handler.go Show resolved Hide resolved
@hperl hperl requested a review from aeneasr August 2, 2023 11:38
aeneasr
aeneasr approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing but otherwise LGTM

@aeneasr aeneasr merged commit d4605bb into master Aug 7, 2023
6 checks passed
@aeneasr aeneasr deleted the oidc-vc branch August 7, 2023 11:35
shipperizer pushed a commit to shipperizer/fosite that referenced this pull request Jan 3, 2024
@hperl @shipperizer
feat: add verifiable credentials handler (ory#758)
d5dac14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr aeneasr approved these changes

Assignees

@hperl hperl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hperl @aeneasr