fix: add missing ctx argument to IsRedirectURISecureStrict #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
reviewed
Feb 13, 2024
| @@ -180,7 +180,7 @@ func IsRedirectURISecure(ctx context.Context, redirectURI *url.URL) bool { | |||
| // IsRedirectURISecureStrict is stricter than IsRedirectURISecure and it does not allow custom-scheme | |||
| // URLs because they can be hijacked for native apps. Use claimed HTTPS redirects instead. | |||
| // See discussion in https://github.com/ory/fosite/pull/489. | |||
| func IsRedirectURISecureStrict(redirectURI *url.URL) bool { | |||
| func IsRedirectURISecureStrict(ctx context.Context, redirectURI *url.URL) bool { | |||
There was a problem hiding this comment.
If we don't use it in the function, why add it?
There was a problem hiding this comment.
Because you added it to IsRedirectURISecure. :-) So IsRedirectURISecure is used for RedirectSecureChecker config and IsRedirectURISecureStrict is a stricter version of IsRedirectURISecure. So if one wants to use it as a config value, currently there is a signature mismatch.
So this is just updating the signature to be compatible with RedirectSecureChecker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue or Design Document
I think this was missed when
ctxwas added around. Now it cannot be used forRedirectSecureCheckerconfig.Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.